PHP - Introduce Mutation testing #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciaranmcnulty
force-pushed
the
mutation-testing
branch
7 times, most recently
from
906dac7
to
ca6903f
Compare
ciaranmcnulty
force-pushed
the
mutation-testing
branch
from
ca6903f
to
2ccdcf2
Compare
|
I've cleaned out a lot of the 'fixes' as they were cluttering the PR - I'll do them after this is merged It looks like the PHP composer install is being rate-limited at GitHub, which I don't think should happen in GHA! Investigating... |
ciaranmcnulty
added a commit
to ciaranmcnulty/cucumber-gherkin
that referenced
this pull request
Nov 13, 2022
This writes the github auth token to a config file in ~/.composer, which then uses it when downloading packages This will help with github rate limiting, as was happening on cucumber#52 Documentation here: https://github.com/shivammathur/setup-php#github-composer-authentication
|
ok, #55 might fix the rate limits + I'll rebase on top of that when it's merged |
ciaranmcnulty
changed the title
mpkorstanje
pushed a commit
that referenced
this pull request
Nov 13, 2022
This writes the github auth token to a config file in ~/.composer, which then uses it when downloading packages This will help with github rate limiting, as was happening on #52 Documentation here: https://github.com/shivammathur/setup-php#github-composer-authentication
ciaranmcnulty
force-pushed
the
mutation-testing
branch
from
2ccdcf2
to
8e97978
Compare
ciaranmcnulty
commented
Nov 13, 2022
| @@ -39,12 +29,13 @@ clean: ## Remove all build artifacts and files generated by the acceptance tests | |||
|
|
|||
| .DELETE_ON_ERROR: | |||
|
|
|||
| acceptance: .built $(TOKENS) $(ASTS) $(PICKLES) $(ERRORS) $(SOURCES) ## Build acceptance test dir and compare results with reference | |||
| acceptance: .built ## Test parser against test data | |||
There was a problem hiding this comment.
Not sure if this should be .PHONY now?
There was a problem hiding this comment.
You can remove the goal entirety.
Do update the php/README.md with info about the structure.
ciaranmcnulty
force-pushed
the
mutation-testing
branch
from
8e97978
to
09eca5c
Compare
mpkorstanje
reviewed
Nov 13, 2022
| @@ -56,8 +57,23 @@ jobs: | |||
| run: | | |||
| vendor/bin/php-cs-fixer --dry-run --diff fix | |||
| vendor/bin/psalm --no-cache | |||
| vendor/bin/phpunit | |||
| vendor/bin/phpunit --testsuite unit | |||
There was a problem hiding this comment.
We can run all the tests in a regular run. The separation between acceptance and unit existed only because we had different methods for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces mutation testing using Infection, just for the non-generated code
In order to be able to use the acceptance tests with the mutation testing tools, the acceptance testing has been transposed into PHPUnit rather than the existing bash/make version
The
gherkin-generate-tokensbinary is removed as that was only for testing, but thebin/gherkinis left the same