Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[.NET] Update target frameworks #265

Merged
merged 5 commits into from
Aug 15, 2024
Merged

[.NET] Update target frameworks #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0c416ae
Update target frameworks for .NET
Romfos Aug 9, 2024
e191cc9
Update changelog
Romfos Aug 9, 2024
73a03b6
Update changelog
Romfos Aug 9, 2024
99392ac
Merge branch 'main' into main
mpkorstanje Aug 15, 2024
2a090b5
Update CHANGELOG.md
mpkorstanje Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/test-dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ jobs:
- uses: actions/setup-dotnet@v4
with:
dotnet-version: |
6.0.x
7.0.x
8.0.x
- run: dotnet test
working-directory: dotnet
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt
## [Unreleased]
### Changed
- [Ruby] Upgraded messages support to permit up to v26
- [.NET] Drop unsupported frameworks. Now supported target frameworks are .NET 8, .NET Framework 4.6.2, .NET Standard 2.0

## [29.0.0] - 2024-08-12
### Added
Expand Down
2 changes: 1 addition & 1 deletion dotnet/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>

<PropertyGroup>
<LangVersion>11</LangVersion>
<LangVersion>12</LangVersion>
</PropertyGroup>

</Project>
2 changes: 1 addition & 1 deletion dotnet/Gherkin.Specs/Gherkin.Specs.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>net8.0;net7.0;net6.0</TargetFrameworks>
<TargetFrameworks>net8.0</TargetFrameworks>
<OutputType>Exe</OutputType>
<StartupObject>Gherkin.Specs.CLI.Program</StartupObject>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion dotnet/Gherkin/Gherkin.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>net6.0;netstandard2.0;net462</TargetFrameworks>
<TargetFrameworks>net8.0;netstandard2.0;net462</TargetFrameworks>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<NoWarn>1591</NoWarn>
<Deterministic Condition="'$(Configuration)' == 'Release'">false</Deterministic>
Expand Down
4 changes: 2 additions & 2 deletions dotnet/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ clean: ## Remove all build artifacts and files generated by the acceptance tests

acceptance: .built $(TOKENS) $(ASTS) $(PICKLES) $(ERRORS) $(SOURCES) ## Build acceptance test dir and compare results with reference

.built: $(SOURCE_FILES) Gherkin.Specs/bin/Debug/net6.0/Gherkin.Specs.dll
.built: $(SOURCE_FILES) Gherkin.Specs/bin/Debug/net8.0/Gherkin.Specs.dll
touch $@

Gherkin.Specs/bin/Debug/net6.0/Gherkin.Specs.dll:
Gherkin.Specs/bin/Debug/net8.0/Gherkin.Specs.dll:
dotnet test

$(GHERKIN_PARSER): $(GHERKIN_RAZOR) ../gherkin.berp
Expand Down
2 changes: 1 addition & 1 deletion dotnet/bin/gherkin
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash
set -euf -o pipefail

arch="net6.0"
arch="net8.0"

dotnet "Gherkin.Specs/bin/Debug/$arch/Gherkin.Specs.dll" events "${@:1}"
2 changes: 1 addition & 1 deletion dotnet/bin/gherkin-generate-tokens
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash
set -euf -o pipefail

arch="net6.0"
arch="net8.0"

dotnet "Gherkin.Specs/bin/Debug/$arch/Gherkin.Specs.dll" tokens "${@:1}"
Loading