Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gujarati translation for Rule #249

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Conversation

hardikthanth
Copy link
Contributor

@hardikthanth hardikthanth commented Jun 3, 2024

πŸ€” What's changed?

⚑️ What's your motivation?

🏷️ What kind of change is this?

  • πŸ“– Documentation (improvements without changing code)
  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • πŸ› Bug fix (non-breaking change which fixes a defect)
  • ⚑ New feature (non-breaking change which adds new behaviour)
  • πŸ’₯ Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

πŸ“‹ Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@luke-hill
Copy link
Contributor

Hi @hardikthanth

Can you read https://github.com/cucumber/gherkin/blob/main/CONTRIBUTING.md#adding-or-updating-an-i18n-language as there is a little more work that needs to be done before this can be merged.

Can you also add a changelog entry, similar ones exist from recently you can just copy and paste

@kieran-ryan kieran-ryan changed the title Update gherkin-languages.json Gujarati Gujarati translation for Rule Jul 12, 2024
@kieran-ryan kieran-ryan added the πŸ› bug Defect / Bug label Jul 12, 2024
@kieran-ryan kieran-ryan merged commit 77c79ba into cucumber:main Jul 12, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ› bug Defect / Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants