Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perl, .Net: provide informative exception for trailing escapes in tables #245

Merged
merged 12 commits into from
Jul 8, 2024
Merged

Perl, .Net: provide informative exception for trailing escapes in tables #245

merged 12 commits into from
Jul 8, 2024

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Apr 13, 2024 •
edited
Loading

Quick PR to kick of CI and see what happens when tables have extra content with escaped pipes.

🤔 What's changed?

See the previous fixes for python #241 and ruby #244. This time with additional test data.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje mpkorstanje changed the title Extra table content Add test case for extra table content Apr 13, 2024
@mpkorstanje mpkorstanje changed the title Add test case for extra table content .Net, Perl: provide informative exception for trailing escapes in tables Jul 8, 2024
@mpkorstanje mpkorstanje marked this pull request as ready for review July 8, 2024 19:51
@mpkorstanje mpkorstanje changed the title .Net, Perl: provide informative exception for trailing escapes in tables Perl, .Net: provide informative exception for trailing escapes in tables Jul 8, 2024
@mpkorstanje mpkorstanje merged commit 89b7199 into main Jul 8, 2024
32 checks passed
@mpkorstanje mpkorstanje deleted the test-extra-table-content branch July 8, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mpkorstanje