Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide trailing space in Irish keywords #243

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Conversation

kieran-ryan
Copy link
Member

@kieran-ryan kieran-ryan commented Apr 10, 2024

🤔 What's changed?

  • Spaces are used at the end of step keywords e.g. Given and have been applied to the Irish translation
  • Applied translations that were partially applied across language implementations

⚡️ What's your motivation?

  • As spaces were missing, and with the language server using the official gherkin parser; steps were incorrectly marked undefined when a step was introduced between the step keyword and the step text; as the space was being considered part of the step text, instead of typically part of the step keyword. This resolves that issue
  • Ensure language translations are fully aligned and up to date
Screenshot 2024-04-10 at 22 11 33

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:


This text was originally generated from a template, then edited by hand. You can modify the template here.

@kieran-ryan kieran-ryan added the 🐛 bug Defect / Bug label Apr 10, 2024
@kieran-ryan kieran-ryan self-assigned this Apr 10, 2024
@kieran-ryan kieran-ryan changed the title Missing trailing space in Irish keywords Provide trailing space in Irish keywords Apr 10, 2024
@kieran-ryan kieran-ryan marked this pull request as ready for review April 10, 2024 21:21
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, also looks like you fixed something in Tamil. That would be worth it's own changelog note.

gherkin-languages.json Show resolved Hide resolved
@kieran-ryan kieran-ryan merged commit f8425ca into main Apr 11, 2024
30 checks passed
@kieran-ryan kieran-ryan deleted the missing-spaces-irish branch April 11, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Defect / Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants