Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cpp build #206

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Fix cpp build #206

merged 1 commit into from
Jan 4, 2024

Conversation

mpkorstanje
Copy link
Contributor

🤔 What's changed?

Pinned messages to v24.0.1.

⚡️ What's your motivation?

CI Breaks with

https://github.com/cucumber/gherkin/actions/runs/7368444336/job/20053098978

CMake Error at CMakeLists.txt:13 (find_package):
  Could not find a package configuration file provided by "cucumber-messages"
  with any of the following names:

    cucumber-messagesConfig.cmake
    cucumber-messages-config.cmake

  Add the installation prefix of "cucumber-messages" to CMAKE_PREFIX_PATH or
  set "cucumber-messages_DIR" to a directory containing one of the above
  files.  If "cucumber-messages" provides a separate development package or
  SDK, be sure it has been installed.

Presumably because of cucumber/messages#187

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

A proper fundamental fix would be nice, but if this passes CI we can continue with other PRs.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje
Fix cpp build
0c13e0f 
The commits on main after v24.0.1 broke some
expectations in Gherkin.
@mpkorstanje mpkorstanje marked this pull request as ready for review January 4, 2024 11:33
@mpkorstanje mpkorstanje merged commit d6f8d0b into main Jan 4, 2024
2 checks passed
@mpkorstanje mpkorstanje deleted the fix-cpp-build branch January 4, 2024 11:34
@mpkorstanje mpkorstanje mentioned this pull request Jan 4, 2024
Merged
7 tasks
mpkorstanje added a commit to cucumber/renovate-config that referenced this pull request Jan 4, 2024
@mpkorstanje
Support cpp/deps.txt
5e07e78 
Our cpp projects use deps.txt to list and download their dependencies.
These should be automatically updated.

This is especially important because floating dependencies may break the
build when we don't expect it to. E.g: cucumber/gherkin#206
@mpkorstanje mpkorstanje mentioned this pull request Jan 4, 2024
Merged
mpkorstanje added a commit to cucumber/renovate-config that referenced this pull request Jan 4, 2024
@mpkorstanje
Support cpp/deps.txt
944cc54 
Our cpp projects use deps.txt to list and download their dependencies.
These should be automatically updated.

This is especially important because floating dependencies may break the
build when we don't expect it to. E.g: cucumber/gherkin#206
@chybz
Copy link
Contributor

chybz commented Jan 4, 2024

Having look asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chybz chybz Awaiting requested review from chybz

@ursfassler ursfassler Awaiting requested review from ursfassler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpkorstanje @chybz