Add docker container to generate parsers and languages #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-hill
reviewed
Sep 7, 2023
ehuelsmann
force-pushed
the
dockerized-berp
branch
from
d2156a2
to
cc143f5
Compare
|
Branch rebased (explaining the force-push). |
luke-hill
reviewed
Oct 19, 2023
mpkorstanje
added a commit
that referenced
this pull request
Aug 2, 2024
The go parser is currently generated and then formatted. This however requires that go is installed when generating the parser. This added dependency makes code generation more complicated than it needs to be as this is yet another tool people need to install. This in turn makes #154 more complicated than it needs to be. By making the code generator generate formatted code we avoid this problem all together.
mpkorstanje
added a commit
that referenced
this pull request
Aug 2, 2024
The go parser is currently generated and then formatted. This however requires that go is installed when generating the parser. This added dependency makes code generation more complicated than it needs to be as this is yet another tool people need to install. This in turn makes #154 more complicated than it needs to be. By making the code generator generate formatted code we avoid this problem all together.
mpkorstanje
changed the title
|
Cheers @ehuelsmann ! Took me a while to get to this but this is actually really good improvement. A belated thanks for kicking it off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
A dockerized version of Berp.
⚡️ What's your motivation?
The
cucumber/buildcontainer is huge. Most people only need it to run Berp. So, instead of downloading and maintaining a multi-gigabyte container, lets use a lean one with exactly one purpose.🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
This container likely causes permissions conflicts: the
cukebotuser has hard-coded UID 1000 whereas not everybody will be running as that user. The release container had trickery to be able to run "as the current user". Is it easy to transplant and do we want/need that? (was it even in the container? Or was it in the makefile before?)📋 Checklist: