-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove wip tag #982
Remove wip tag #982
Conversation
@@ -6,6 +6,7 @@ | |||
|
|||
### Bugfixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was not supposed to be in this PR! I thought I had pushed this directly to master previously :(
Oh no, looks like this feature doesn't, in fact, pass, which means we probably shouldn't have merged #920. I'll have to look into what's going on. |
@danascheider The retry filter is never added to the filters in the runtime. Your step definitions for the retry feature does not work. One problem is that their state is not reset between scenarios. I also made this comment on the PR. |
Oh sorry, I didn't see that! I'll check it out when I get to the office. |
See also #981 :) |
Closed in favour of #981 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This PR removes the
@wip
tag fromretry_failing_tests.feature
.Details
Since
retry_failing_tests.feature
is now fully implemented and passes, it should not be tagged as@wip
as this will break the build after #981 is merged.Motivation and Context
Since we have decided not to allow
@wip
features on master, we need to remove the@wip
tag from features already on master (and, of course, fix ones that don't pass). This will prevent the build from breaking due to the presence of features that should not have been merged. (Something tells me this whole paragraph doesn't make much sense.)How Has This Been Tested?
The feature was already passing, so removing the tag doesn't require additional tests.