Guard against the require succeeding, but not properly loading a module. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related issue for TeamCity: http://youtrack.jetbrains.net/issue/TW-17414 |
…le. Specifically, TeamCity attempts to monkeypatch minitest if it's defined, but ends up defining a minimal module causing test failures.
|
Just updated the commit to add comments. Thanks! |
|
Ah, looks like the force push removed your comment asking for inline comments, Aslak. |
|
Hi Aslak, Just checking in regarding this -- you said you'd pull this in about a month back if I added the comments in. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard against the require succeeding, but not properly loading a module. Specifically, TeamCity attempts to monkeypatch minitest if it's defined, but ends up defining a minimal module causing test failures.