Scenario outlines make the JSON formatter fail (an exception is raised)

[brasmusson]

The scenario added in this PR with the @wip-new-core tag, does pass in v1.3.x (but it is not included in the json_formatter.feature until #700).

The problem is that in gherkin_formatter_adapter the code relies on using the gherkin_statement method on the AST classes. This does not work on the AST classes Core::Ast::ScenarioOutline nor Core::Ast::ExamplesTable.

Requires cucumber/cucumber-ruby-core#59

[brasmusson]

With cucumber/cucumber-ruby-core#59 and the fix in normalise_output.rb, the remaining JSON diff is:

      -        "match"=>{"location"=>"features/step_definitions/steps.rb:1"}}],
      +        "match"=>{"location"=>"features/outline.feature:4"}}],

That is in v1.3.x the match of the step in the scenario outline refers to a step definition, whereas it in v2.0 refers to the step location itself.

The step definition referred to in v1.3.x is actually not all that accurate, only when <status> has the value pass, steps.rb:1 will be executed, when <status> has the value fail, it is actually steps.rb:5 that is executed.

[mattwynne]

I don't think a match is even relevant in the data at that point - it might match many different step definitions through the examples, depending on what gets substituted.

[mattwynne]

I think the data model is broken here. It would be better, IMO, to have completely separate data about results from test-cases that uses the id of the scenario / example row to match it back to the gherkin.

But that's a different problem. I'm going to change the feature so this passes.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.