bugfix: Handle Cucumber-Wire issue when parameter type cannot be specified on Envelope #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-hill
changed the title
|
@canmor - Can you let me know if this fixes your issue. If so will get this merged and cut soon |
|
cc/ @ursfassler if you want to stay abreast of things that are currently being fixed that are likely to affect cpp |
- When step match argument cannot detect the parameter type name, return `nil` and then have the optional param fed as `nil` - When there is no parameter type (Because of legacy system), then return `nil` and have the optional param fed as `nil`
luke-hill
force-pushed
the
bugfix/make_parameter_type_optional_in_envelope
branch
from
c526dde
to
e3f08be
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempts to fix Handle NME from cucumber-wire
Type of change
Please delete options that are not relevant.
Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses