Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rubocop #1566

Merged
merged 41 commits into from
Nov 17, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
d650418
Upgrade Rubocop to 0.92
aurelien-reeves Aug 4, 2021
9dc538d
Fix offence: explicitely extend Object class
aurelien-reeves Aug 4, 2021
829c0f6
Restore the extension of the global namespace
aurelien-reeves Aug 5, 2021
98f7056
Merge branch 'main' into upgrade-rubocop
aurelien-reeves Aug 5, 2021
1d5e463
Upgrade rubocop to 1.0
aurelien-reeves Aug 5, 2021
2be14ae
Apply safe auto-correct
aurelien-reeves Aug 5, 2021
1917f85
Apply unsafe autocorrect
aurelien-reeves Aug 5, 2021
aa4c94b
Apply manual updaates to fix rubocop offenses
aurelien-reeves Aug 5, 2021
0e2d9a5
Refactor calculator example to prevent disabling rubocop
aurelien-reeves Aug 6, 2021
ac4ffb9
Do not fail fast workflow
aurelien-reeves Aug 6, 2021
922ae1b
Fix jruby CI job
aurelien-reeves Aug 6, 2021
9203b24
Add ruby 2.3 to CI
aurelien-reeves Aug 6, 2021
d510489
Revert "Add ruby 2.3 to CI"
aurelien-reeves Aug 6, 2021
0180d56
Upgrade rubocop to 1.1.0
aurelien-reeves Aug 25, 2021
640a345
Remove disabling of rubocop/redundant begin
aurelien-reeves Oct 27, 2021
025141e
Merge remote-tracking branch 'origin/main' into upgrade-rubocop
aurelien-reeves Oct 27, 2021
eaecf99
Fix broken tests after merging main
aurelien-reeves Oct 27, 2021
f0ee77d
Remove inline rubocop magic comment
aurelien-reeves Oct 27, 2021
d92d712
Fix rubocop Style/RegexpLiteral offenses
aurelien-reeves Oct 27, 2021
c8ee7fb
Remove a few rubocop magic comments
aurelien-reeves Oct 27, 2021
a453bcc
Bump rubotop to 1.4
aurelien-reeves Nov 3, 2021
8100756
Fix Cucumber::Undefined Style/RaiseArgs error
aurelien-reeves Nov 3, 2021
06ab3e4
Bump rubocop to 1.10.0
aurelien-reeves Nov 3, 2021
a41017f
Fix offense with regexp
aurelien-reeves Nov 3, 2021
201fbb3
Disable Metrics/ParameterLists with Cucumber::Cli::Main#initialize
aurelien-reeves Nov 3, 2021
8d5e4bc
Bump rubocop to 1.18.4
aurelien-reeves Nov 3, 2021
9897467
Bump rubocop to 1.19.1
aurelien-reeves Nov 3, 2021
31d6847
Fix offenses
aurelien-reeves Nov 3, 2021
07a3377
Bump rubocop to v1.22.3
aurelien-reeves Nov 3, 2021
67d4bae
Remove exclusion of Bundler/DuplicatedGem
aurelien-reeves Nov 4, 2021
80fe549
Enable Layout/EndOfLine: we don't use Appveyor anymore
aurelien-reeves Nov 4, 2021
d8b4c16
Enable Layout/EmptyLineAfterGuardClause
aurelien-reeves Nov 4, 2021
4c3abc5
Autocorrect Layout/EmptyLineAfterGuardClause
aurelien-reeves Nov 4, 2021
0376aa4
Enforce LF with Layout/EndOfLine
aurelien-reeves Nov 4, 2021
9b6dac6
Update spec/support/fake_objects.rb
aurelien-reeves Nov 4, 2021
3f6d27f
Fix typo in comments
aurelien-reeves Nov 4, 2021
28e7b84
Update lib/cucumber/glue/step_definition.rb
aurelien-reeves Nov 4, 2021
5575e94
Move some call to 'super' to bottom of methods
aurelien-reeves Nov 4, 2021
c6c22fa
Remove useless code
aurelien-reeves Nov 17, 2021
28f0d3b
Restore ProtoWorld 'useless' methods for documentation purpose
aurelien-reeves Nov 17, 2021
8222d2b
Merge branch 'main' into upgrade-rubocop
aurelien-reeves Nov 17, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ is_windows = !!(RbConfig::CONFIG['host_os'] =~ /mswin|mingw|cygwin/)
# rubocop:enable Style/DoubleNegation

install_if -> { !is_windows } do
gem 'rubocop', '~> 0.89', '= 0.89.1'
gem 'rubocop', '~> 0.92', '= 0.92.0'
gem 'rubocop-packaging', '~> 0.3', '= 0.5.1'
end
6 changes: 4 additions & 2 deletions lib/cucumber/glue/dsl.rb
Original file line number Diff line number Diff line change
Expand Up @@ -136,5 +136,7 @@ def register_rb_step_definition(regexp, symbol = nil, options = {}, &proc)
end
end

# TODO: can we avoid adding methods to the global namespace (Kernel)
extend(Cucumber::Glue::Dsl)
class Object
aurelien-reeves marked this conversation as resolved.
Show resolved Hide resolved
# TODO: can we avoid adding methods to the global namespace (Kernel)
prepend(Cucumber::Glue::Dsl)
end