Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 3.2.0 #1414

Closed
wants to merge 5 commits into from
Closed

Prepare release 3.2.0 #1414

wants to merge 5 commits into from

Conversation

vincent-psarga
Copy link
Contributor

@vincent-psarga vincent-psarga commented Apr 28, 2020

Note: this should not be merged back to master, simply do a release with:

@vincent-psarga
Copy link
Contributor Author

So there's no Webrick available for Ruby 2.2 apparently (ruby/webrick@6259c37 - it used to support 2.5+ and went down to 2.3 if I understand this correctly).

I'm puzzled on how to handle that:

  • do a release knowing that we have a dev_dependency failing for Ruby 2.2 (which EOL was 2 years ago) ?
  • remove the tests related to the --out=url option that rely on Webrick (knowing that this will be the last 3.x release on cucumber-ruby and work will now be done on master where we still have the tests working)

@vincent-psarga vincent-psarga marked this pull request as ready for review April 28, 2020 09:19
@mattwynne mattwynne deleted the prepare-release-3.2.0 branch May 1, 2021 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant