Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tag expressions from the cucumber-tag_expressions gem. #1054

Merged
merged 1 commit into from
Feb 15, 2017

Conversation

brasmusson
Copy link
Contributor

Summary

Support standard library tag expressions from the cucumber-tag_expressions gem.

Details

The tag limits from the --tags options are stripped of and handled separately, so that the stored tag expressions can be passed the tag expressions library directly.

Old style tag expressions are deprecated but still handled correctly.

Requires cucumber/cucumber-ruby-core#116

Closes #1003

How Has This Been Tested?

Features and spec are updated accordingly.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I've added tests for my code
  • I've updated the help test (-h option)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mattwynne
Copy link
Member

@brasmusson you left "i have updated the documentation unticked" but you've changed https://github.com/cucumber/cucumber-ruby/pull/1054/files#diff-f622824b18af7ee8c0203bd93e1c7d7d - I think that counts!

@mattwynne
Copy link
Member

Thanks for making it backwards compatible but adding deprecation warnings. Perfect!

@mattwynne mattwynne merged commit 5f811ce into master Feb 15, 2017
mattwynne added a commit that referenced this pull request Feb 15, 2017
@brasmusson brasmusson deleted the use-tag-expressions branch February 16, 2017 12:25
@brasmusson
Copy link
Contributor Author

Before removing the backward compatibility (in Cucumber-Ruby v4?) Aruba needs to be updated to not use ~ as "not" in tagged hooks (I suppressed the warning for it - since the user seeing the warning cannot just change the Aruba code).

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants