Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add hook method name to TeamCityPlugin #2881

Merged
merged 3 commits into from
May 16, 2024

Conversation

maestro-game
Copy link
Contributor

Hi, this closes #2798. changes:

🤔 What's changed?

The TeamCityPlugin for IntelliJ IDEA now uses the hook's method name for the name of the hook itself.
For example, if we have a hook with the method name com.example.HookDefinition.beforeHook(), the generated name will be Before(beforeHook).
If we have a hook with the method name com.example.HookDefinition.<init>(HookDefinition.java:12), the generated name will be Before(HookDefinition).
If the hook's method can't be identified then fallback to simple hook name.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@maestro-game maestro-game linked an issue May 15, 2024 that may be closed by this pull request
@mpkorstanje mpkorstanje self-requested a review May 16, 2024 17:20
@mpkorstanje mpkorstanje changed the title Resolved issue with hooks namings [Core] Add hook method name to TeamCityFormatter May 16, 2024
@mpkorstanje mpkorstanje changed the title [Core] Add hook method name to TeamCityFormatter [Core] Add hook method name to TeamCityPlugin May 16, 2024
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers! Looks good. Thanks for contributing.

@mpkorstanje mpkorstanje merged commit 5d03555 into main May 16, 2024
6 checks passed
@mpkorstanje mpkorstanje deleted the 2798-allow-beforeafter-hooks-to-be-renamed branch May 16, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Before/After Hooks to be renamed
2 participants