[Core] Merge duplicate plugin options #2191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to declare duplicate plugins. Either through `@CucumberOptions`, or `cucumber.plugin`, ect or a combination thereof. This can be used to ensure certain plugins are always active during a build in CI. Merging duplicate plugin options should ensure that plugins are not instantiated twice with the same output. Fixes: #2190
Codecov Report
@@ Coverage Diff @@
## main #2191 +/- ##
============================================
- Coverage 82.82% 82.77% -0.05%
- Complexity 2327 2330 +3
============================================
Files 306 306
Lines 8296 8303 +7
Branches 762 764 +2
============================================
+ Hits 6871 6873 +2
- Misses 1116 1118 +2
- Partials 309 312 +3
Continue to review full report at Codecov.
|
|
Generated code. Thanks codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to declare duplicate plugins. Either through
@CucumberOptions,or
cucumber.plugin, ect or a combination thereof. This can be used to ensurecertain plugins are always active during a build in CI.
Merging duplicate plugin options should ensure that plugins are not
instantiated twice with the same output.
Fixes: #2190