[Core] Default to --strict mode

[mpkorstanje]

Unlike other implementations Cucumber-JVM defaults to --non-strict mode. By defaulting to --strict Cucumber follows the same standards as other implementations.

Additionally the option to set strict mode adds complexity for consumers of Cucumbers output. They have to interpret Cucumbers 6 scenario outcomes with this in mind. By removing --strict/--non-strict mode we remove this complexity all together.

With PR Cucumber will:

• default to --strict
• throw an error on --non-strict.
• warn when --strict is used.
• only print snippets as part of the exception thrown by JUnit rather then use the summary printer
• only print snippets as part of the exception thrown by TestNG rather then use the summary printer

Partial fix for #1788, cucumber/common#714

Types of changes

• Bug fix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

• I've added tests for my code.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[coveralls]

Coverage decreased (-0.1%) to 87.124% when pulling 08cc8dd on remove-strict into 6c0df8e on v6.x.x.

[sebrose]

The title of this PR (and the comment in the Changelog) imply only a change of default. It looks like the whole idea of non-strict has been removed - although the help text still says:
cucumber.execution.strict= # true or false. default: false.

Am I missing something?

[mpkorstanje]

Internally the implementation is gone. However we're still in the process of phasing out the user facing part.

cucumber-jvm/core/src/main/java/io/cucumber/core/options/CucumberPropertiesParser.java

Lines 137 to 142 in d3f7956

	private static void errorOnNonStrict(Boolean strict) {
	if (!strict) {
	throw new CucumberException(EXECUTION_STRICT_PROPERTY_NAME
	+ "=false is no longer effective. Please use =true (the default) or remove this property");
	}
	}

[Colin-Heyl]

Hi, wondering if someone can verify something for me?

We're using Cucumber at the moment and a test will not fail, if a feature is not found.

Shouldn't that happen if strict mode is now the default? Or has strict functionality just been stripped out for some reason?

[mpkorstanje]

Strict mode only affects translating PENDING, UNDEFINED, AMBIGUOUS steps results into a pass or fail. It does not do anything w.r.t to features being discovered.

If you have a feature request, please create a new issue though.