[JUnit] Invoke @BeforeClass before TestRunStarted event #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
force-pushed
the
run-junit-before-class-before-test-run-started-event
branch
from
0392d28 to
267e6a3
Compare
JUnit is running Cucumber so the expectation is that JUnit's `@BeforeClass` and `@AfterClass` methods are invoked respectively before and after all events emitted by Cucumber. However because the `TestRunStarted` event was emitted in the constructor of `Cucumber` it would precede the the invocation of `@BeforeClass`. In older versions of Cucumber sending the `TestSourceRead` events was coupled to reading the test sources. This made it impossible to read the features ahead of time -required to to create the test description tree and fail on lexer errors- and send `TestRunStarted` after `@BeforeClass`. This is no longer case since #1367 and so this problem can be resolved.
mpkorstanje
force-pushed
the
run-junit-before-class-before-test-run-started-event
branch
from
267e6a3 to
033c91a
Compare
mpkorstanje
deleted the
run-junit-before-class-before-test-run-started-event
branch
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Invoke @BeforeClass before TestRunStarted event
JUnit is running Cucumber so the expectation is that JUnit's
@BeforeClassand@AfterClassmethods are invoked respectively beforeand after all events emitted by Cucumber. However because the
TestRunStartedevent was emitted in the constructor ofCucumberitwould precede the the invocation of
@BeforeClass.In older versions of Cucumber sending the
TestSourceReadevents wascoupled to reading the test sources. This made it impossible to read the
features ahead of time -required to to create the test description
tree and fail on lexer errors- and send
TestRunStartedafter@BeforeClass.This is no longer case since #1367 and so this problem can be resolved.
Types of changes
Checklist: