Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Pass class loader to ServiceLoader.load invocations #2220

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

mpkorstanje
Copy link
Contributor

Fixes: #2217, #2219

@mpkorstanje mpkorstanje force-pushed the pass-the-class-loader branch from 13dcc3b to 5a991e5 Compare January 23, 2021 18:00
@codecov
Copy link

codecov bot commented Jan 23, 2021

Codecov Report

Merging #2220 (4b261e6) into main (31c1361) will increase coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2220      +/-   ##
============================================
+ Coverage     82.80%   82.81%   +0.01%     
- Complexity     2331     2332       +1     
============================================
  Files           306      306              
  Lines          8303     8308       +5     
  Branches        764      764              
============================================
+ Hits           6875     6880       +5     
+ Misses         1117     1116       -1     
- Partials        311      312       +1     
Impacted Files Coverage Δ Complexity Δ
...umber/core/runtime/ObjectFactoryServiceLoader.java 48.97% <75.00%> (+0.09%) 3.00 <3.00> (ø)
...io/cucumber/core/runtime/BackendServiceLoader.java 100.00% <100.00%> (ø) 6.00 <1.00> (ø)
...rc/main/java/io/cucumber/core/runtime/Runtime.java 93.13% <100.00%> (ø) 12.00 <0.00> (ø)
...latform/engine/CucumberEngineExecutionContext.java 84.21% <100.00%> (ø) 8.00 <0.00> (ø)
...unit/src/main/java/io/cucumber/junit/Cucumber.java 100.00% <100.00%> (ø) 9.00 <0.00> (ø)
.../java/io/cucumber/testng/TestNGCucumberRunner.java 96.07% <100.00%> (ø) 7.00 <0.00> (ø)
...n/java/io/cucumber/core/resource/ClassLoaders.java 33.33% <0.00%> (+33.33%) 1.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31c1361...4b261e6. Read the comment docs.

@mpkorstanje mpkorstanje force-pushed the pass-the-class-loader branch from 5a991e5 to 61c8c36 Compare January 23, 2021 18:40
Copy link

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks 👍

@mpkorstanje mpkorstanje force-pushed the pass-the-class-loader branch from 61c8c36 to 226eaaf Compare February 11, 2021 16:47
@mpkorstanje mpkorstanje force-pushed the pass-the-class-loader branch from 226eaaf to 4b261e6 Compare February 11, 2021 16:50
@mpkorstanje mpkorstanje merged commit c273364 into main Feb 11, 2021
@mpkorstanje mpkorstanje deleted the pass-the-class-loader branch February 11, 2021 17:08
This was referenced Mar 9, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Classloader flaw in BackendServiceLoader
2 participants