Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classloader flaw in ObjectFactoryServiceLoader #2219

Closed
laeubi opened this issue Jan 23, 2021 · 0 comments
Closed

Classloader flaw in ObjectFactoryServiceLoader #2219

laeubi opened this issue Jan 23, 2021 · 0 comments
Labels
🐛 bug Defect / Bug

Comments

@laeubi
Copy link

laeubi commented Jan 23, 2021

Describe the bug
Currently ObjectFactoryServiceLoader don't use (in contrast to the other classes) the classlaoder passed to Runtime.builder().withClassloader(...) this loads to problems in cases whith classloader restrictions

Expected behavior
ObjectFactoryServiceLoader gets the serviceloader and uses it for service lookup.
mpkorstanje added a commit that referenced this issue Jan 23, 2021
@mpkorstanje
[Core] Pass class loader to ServiceLoader.load invocations
13dcc3b 
Fixes: #2217, #2219
@mpkorstanje mpkorstanje mentioned this issue Jan 23, 2021
Merged
mpkorstanje added a commit that referenced this issue Jan 23, 2021
@mpkorstanje
[Core] Pass class loader to ServiceLoader.load invocations
5a991e5 
Fixes: #2217, #2219
mpkorstanje added a commit that referenced this issue Jan 23, 2021
@mpkorstanje
[Core] Pass class loader to ServiceLoader.load invocations
61c8c36 
Fixes: #2217, #2219
@aslakhellesoy aslakhellesoy added the 🐛 bug Defect / Bug label Feb 2, 2021
mpkorstanje added a commit that referenced this issue Feb 11, 2021
@mpkorstanje
[Core] Pass class loader to ServiceLoader.load invocations
226eaaf 
Fixes: #2217, #2219
mpkorstanje added a commit that referenced this issue Feb 11, 2021
@mpkorstanje
[Core] Pass class loader to ServiceLoader.load invocations
4b261e6 
Fixes: #2217, #2219
mpkorstanje added a commit that referenced this issue Feb 11, 2021
@mpkorstanje
[Core] Pass class loader to ServiceLoader.load invocations (#2220)
c273364 
Fixes: #2217, #2219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Defect / Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aslakhellesoy @laeubi @mpkorstanje