Refactor Runtime.filters and matchesFilters out of Runtime

[mpkorstanje]

To make the first baby steps towards implementing a Cucumber Runner for JUnit 5 we'll need to make it possible to filter a list of features without creating a Runtime instance.

Currently Runtime assembles Runtime.filters internally from RuntimeOptions but only accesses it through Runtime.matchesFilters. This should make it possible to extract Runtime.filters and Runtime.matchesFilters in to Filters class.

It'd be also useful to create a Filters.getFilters() class that handles the creation of a list of filter. This is currently done in Runtime through.

        this.filters = new ArrayList<PicklePredicate>();
        List<String> tagFilters = runtimeOptions.getTagFilters();
        if (!tagFilters.isEmpty()) {
            this.filters.add(new TagPredicate(tagFilters));
        }
        List<Pattern> nameFilters = runtimeOptions.getNameFilters();
        if (!nameFilters.isEmpty()) {
            this.filters.add(new NamePredicate(nameFilters));
        }
        Map<String, List<Long>> lineFilters = runtimeOptions.getLineFilters(resourceLoader);
        if (!lineFilters.isEmpty()) {
            this.filters.add(new LinePredicate(lineFilters));
        }

Desired dependency graph:

RuntimeOptions <--- Filters <--- Runtime (use constructor dependency injection)

[mpkorstanje]

This partially been done by 56c3477

However addLineFilters is duplicated a few times and suffers from a primitive obsession.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.