Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass scenario argument to hooks. Fixes #891 #905

Closed
wants to merge 1 commit into from

Conversation

aslakhellesoy
Copy link
Contributor

Fixes a regression in Before/After so scenario result is passed. Added a regression test.

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks just like the fix needed!

@olleolleolle olleolleolle added the 🐛 bug Defect / Bug label Aug 17, 2017
@charlierudolph
Copy link
Member

From the related issue, I had believed we needed more information (the testCase uri and line). Also I'd prefer if we also update the name so that scenarioResult no longer lives in the codebase

@charlierudolph
Copy link
Member

closing in favor of #919

@charlierudolph charlierudolph deleted the bring-back-scenario-result branch December 8, 2017 17:22
@lock
Copy link

lock bot commented Dec 8, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Defect / Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants