Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display error banner when Reports server returns status code ≠ 2xx #1608

Merged
merged 40 commits into from
Mar 19, 2021
Merged

Display error banner when Reports server returns status code ≠ 2xx #1608

merged 40 commits into from
Mar 19, 2021

Commits on Mar 9, 2021

  1. Add scenario displaying expected result

    @vincent-psarga
    vincent-psarga committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    d115c51 View commit details
    Browse the repository at this point in the history

  2. Display error returned by the server instead of stack trace 

    Update scenario to ensure cucumber execution fails if the server returned an error
    @vincent-psarga
    vincent-psarga committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    513be7e View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Make cucumber-js fail when an error is returned byt the server

    @vincent-psarga
    vincent-psarga committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    e8fa74a View commit details
    Browse the repository at this point in the history

  2. Investigate failing test on CI

    @vincent-psarga
    vincent-psarga committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    7ec1932 View commit details
    Browse the repository at this point in the history

  3. Get it working with node 14

    @vincent-psarga
    vincent-psarga committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    a4e1fd5 View commit details
    Browse the repository at this point in the history

  4. Try getting this working on other node versions than 14 and 15

    @vincent-psarga
    vincent-psarga committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    74b7017 View commit details
    Browse the repository at this point in the history

  5. Rearrange steps like other scenarios

    @vincent-psarga
    vincent-psarga committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    096558b View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Disable fail-fast for CI

    @vincent-psarga
    vincent-psarga committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    ff59a87 View commit details
    Browse the repository at this point in the history

  2. Remove comment in CI config

    @vincent-psarga
    vincent-psarga committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    0c4bf08 View commit details
    Browse the repository at this point in the history

  3. Make error first arg in HttpStream to match conventions

    @aurelien-reeves
    aurelien-reeves committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    6ad6421 View commit details
    Browse the repository at this point in the history

  4. Transform HttpStream from Writable to Transform

    @aurelien-reeves
    aurelien-reeves committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    2dddb53 View commit details
    Browse the repository at this point in the history

  5. Get one more test passing with new Stream

    @vincent-psarga
    vincent-psarga committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    e85eb8b View commit details
    Browse the repository at this point in the history

  6. Refactoring. Next up: Remove sendRequest recursion

    Aslak Hellesøy committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    a525da9 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. Refactor HttpStream to avoid recursion 

    Get banner displayed as expected
    @vincent-psarga
    vincent-psarga committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    2352da8 View commit details
    Browse the repository at this point in the history

  2. fix scenario

    @vincentcapicotto
    vincentcapicotto committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    5af9935 View commit details
    Browse the repository at this point in the history

  3. Try using a single hook to avoid potential race conditions

    @vincent-psarga
    vincent-psarga committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    c5dfdb8 View commit details
    Browse the repository at this point in the history

  4. Try getting more infos about failing tests (maybe)

    @vincent-psarga
    vincent-psarga committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    4af0bdf View commit details
    Browse the repository at this point in the history

  5. Linting ...

    @vincent-psarga
    vincent-psarga committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    b111591 View commit details
    Browse the repository at this point in the history

  6. Move logging, just in case ... (yes the test won't fail anymore ...)

    @vincent-psarga
    vincent-psarga committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    ca39fa7 View commit details
    Browse the repository at this point in the history

  7. More debugging

    @vincent-psarga
    vincent-psarga committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    1bc0165 View commit details
    Browse the repository at this point in the history

  8. Simplify HttpStream implementation

    Aslak Hellesøy committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    aaab859 View commit details
    Browse the repository at this point in the history

  9. Expect HTTP error in output

    Aslak Hellesøy committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    23b7cfe View commit details
    Browse the repository at this point in the history

  10. Fix typo

    Aslak Hellesøy committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    14a0b1d View commit details
    Browse the repository at this point in the history

  11. Add debugging

    Aslak Hellesøy committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    36ca4ff View commit details
    Browse the repository at this point in the history

  12. Add other debug traces

    @aurelien-reeves
    aurelien-reeves committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    77210df View commit details
    Browse the repository at this point in the history

  13. Add other debug traces, also on fake server

    @aurelien-reeves
    aurelien-reeves committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    f58e3e9 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. Use progress formatter in CI

    Aslak Hellesøy committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    f199e3e View commit details
    Browse the repository at this point in the history

  2. add fuzz test about "premature close"

    @vincentcapicotto
    vincentcapicotto committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    d3ab863 View commit details
    Browse the repository at this point in the history

  3. increase race condition test rerun

    @vincentcapicotto
    vincentcapicotto committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    39c47a5 View commit details
    Browse the repository at this point in the history

  4. Test if a simple delay between tests can avoid stream issues

    @vincent-psarga
    vincent-psarga committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    9ad0126 View commit details
    Browse the repository at this point in the history

  5. Another tests for delay between tests

    @vincent-psarga
    vincent-psarga committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    6ba0079 View commit details
    Browse the repository at this point in the history

  6. Linting ...

    @vincent-psarga
    vincent-psarga committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    ed8e58e View commit details
    Browse the repository at this point in the history

  7. Remove tests with timeout

    @vincent-psarga
    vincent-psarga committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    ebecb2b View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Add a missing await in FakeReportServer 

    That may fix the inconsistent tests
    @aurelien-reeves
    aurelien-reeves committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    d4c6970 View commit details
    Browse the repository at this point in the history

  2. Remove useless await in FakeReportServer

    @aurelien-reeves
    aurelien-reeves committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    b50fcd1 View commit details
    Browse the repository at this point in the history

  3. Attempt to avoid race condition in FakeReportServer 

    Two listener on "close" per socket, one destroying it, the other one
resolving the promise when stopping the server.

But the one destroying it may be responsible to also resolving the
promise when stopping the server, so as I understand, it could lead to
resolving the same promise twice for a single socket.
    @aurelien-reeves
    aurelien-reeves committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    1af43ce View commit details
    Browse the repository at this point in the history

  4. Delay server response in test

    Aslak Hellesøy committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    7a62bb5 View commit details
    Browse the repository at this point in the history

  5. Use a (new) random port for each test

    Aslak Hellesøy committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    3272840 View commit details
    Browse the repository at this point in the history

  6. Remove delays and logging

    Aslak Hellesøy committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    36666d3 View commit details
    Browse the repository at this point in the history

  7. Remove test to reproduce race condition error 

    We'll bring it back in a new PR
    @aurelien-reeves
    aurelien-reeves committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    2e744ae View commit details
    Browse the repository at this point in the history