-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test for CLI flag --name + doc update #1445
Conversation
Thanks for doing this @kamolins, looks good. Would you be able to add a test that fails without your change and passes with it? |
@davidjgoss Done! |
@kamolins sorry, looking again at the documentation, this argument is listed as supporting regular expressions, so moving away from You should be able to escape the parentheses and other characters that have regex meaning with backslashes, I think? I do still think there is worthwhile change to make here if you wanted to pivot this PR a bit:
|
@davidjgoss You make a good point! |
@davidjgoss Updated the PR. Lmk if I should do anything else. By the way, my previous push was marked as failed here on node v10 with an unrelated issue. Not really sure what went wrong there. |
Hi @kamolins, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
* CLI flag --name to support special characters * Added unit test for --name flag * Removed semicolon * Reverted changes. Added regex unit test. Updated docs. * Rephrased sentence in docs * use new bullet item for regexp example Co-authored-by: David Goss <[email protected]>
Addresses: #1309