Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish option #1424
Publish option #1424
Changes from 38 commits
9f1c3d1
b3a2880
6ca7dc7
7cbe75d
56c0888
1095cf1
8cdfbca
5171e70
1a00e04
227eea9
632eb6a
f2fe72d
dd0ebcc
10f8184
981a98f
9211f0b
fc17393
b465540
e3f922c
dae139e
c13b8ce
8891803
f1bdd5e
cddacff
28ff61b
599c4ae
80fb637
903ff39
1b898df
6276818
d7a926f
19ade46
231a2d8
be84b19
4a51358
2388754
5097c2a
ed63063
0048be2
841d8d6
508c876
9629395
860f430
272c7bb
2bdd55e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel conflicted about this. This feels annoying to me as a user. Certainly glad we implemented the CLI option to suppress it but why does this need to be outputted a user runs the tool without publish?
Could this be a message shown on install / the help page / somewhere visible on the README?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've already implemented it this way in Cucumber-Ruby and Cucumber-JVM. So far we've not heard any complaints, just positive feedback.
We want as many people as possible to discover this new functionality, and showing it after the run will reach more people than if it's only shown on install and in documentation (which many people never look at).
Let's see if anyone complains.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me. I'll complain. I'm beginning the setup of a test suite and this message is annoying to look at. I tried dropping the module.exports into my step definition file but it didn't get rid of this message. So how do I get rid of this?
And to be clear, I appreciate the thought - but I'm working on a corporate project which will NEVER publish test results onto a public server for security reasons, so I'd rather just have this reminder off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're not supposed to drop that in your step definition files, but in your global
cucumber.js
config file at the root of your project.How can we make this harder to misunderstand @michaelm-rsi?
I completely understand that, which is why we've added an option to turn this off. We're also considering making Cucumber Reports available as a server you can install on-prem.