fix undefined hook parameter #919
Conversation
|
Can we also get access to current (not only failed) scenario name? There can be several scenarios in one feature file and in addition to |
|
url + line uniquely identifies a scenario (or an example of a scenario outline) where the name is not guaranteed to be unique. |
|
I also like matching the event protocol data. Also with some of the ideas for how to view results in the future, I think we will stop saving screenshots to disk and start attaching them and thus let the formatter embed them in an html report. I believe some html reporters already do this. |
| let message = testCase.sourceLocation.uri + ":" + testCase.sourceLocation.line + " " | ||
| if (testCase.result.status === Status.FAILED) { | ||
| message += "failed" | ||
| } else { |
There was a problem hiding this comment.
why do you need an else? seems like the test case only fails.
There was a problem hiding this comment.
Using the same After hook as the previous scenario. I'll join the two scenarios into one
|
In reference to the scenario name, we also use it to register all of the step durations with our analytics system to track performance changes over time. We pretty much harvest all of the metadata about the scenario and record as dimensions, then use them to filter in our charting dashboards. I realize that maybe this type of thing might be better implemented as a reporter, but having the full fidelity of the results available in the hooks has been helpful. |
|
@kriswill yes please use one of the reporters for that. Ideally the support code is only used for running tests and then use reporters when you need more parts of data. The event protocol formatter gives pretty much everything |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
resolves #891