Allow absolute formatter output paths. Fixes #900.

[darrinholst]

I needed this fix to get protractor support for cucumber 3.

• Moved the invalid path scenario that was in multiple_formattters.feature to a new formatter_paths.feature so all the path related scenarios were together.
• Added mustache to get the temp dir into the feature. Added a new replaceContextVariables helper so that I could get the actual temp dir into the feature itself. It felt kind of hacky, but I didn't know of another way besides duplicating step definitions to deal with absolute paths explicitly.

[charlierudolph]

Thoughts on using https://github.com/janl/mustache.js/ for the templating?

[darrinholst]

Yeah...if there were only templating libraries that already handled string replacements 😄. I'll look into this afternoon.

[charlierudolph]

Why are there three curly braces? In the mustache documentation it appears you only need two.

[darrinholst]

mustache html escapes by default which was escaping the /. Triple { returns the raw value.

[charlierudolph]

Cool. Thanks for the explanation

[charlierudolph]

I don't like this step. It appears to only be testing that we are using mustache templates correctly. If we remove this step, does the test still fail if we revert the source code change?

[darrinholst]

My thinking there was that I don't have any control over what tmpDir is. It could be relative to the working directory for all I know so it was just some extra assurance that we are really fixing the problem.

Yes, the test will still fail if it's removed...as long as tmpDir is and always continues to be an absolute path.

I can remove it if you want.

[charlierudolph]

Okay. That sounds like an important precondition. Thoughts on using a 'Given' step instead? Maybe one that says: 'Given "{{{tmpDir}}}" is an absolute path'

[darrinholst]

Sounds reasonable

[aslakhellesoy]

Hi @darrinholst,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
• 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.