Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

writing output to a file with an absolute path prevented in v3.0.0 #900

Closed
travi opened this issue Aug 11, 2017 · 3 comments
Closed

writing output to a file with an absolute path prevented in v3.0.0 #900

travi opened this issue Aug 11, 2017 · 3 comments
Labels
good first issue Good for newcomers 🙏 help wanted Help wanted - not prioritized by core team

Comments

@travi
Copy link
Member

travi commented Aug 11, 2017

because of the path.join with this.cwd passed to fs.open when preparing to write to a file, an absolute path is handled as relative to the project path instead of the root of the system when starting with a leading /.

in my case this is breaking the ability for circle-ci to process the cucumber report since $CIRCLE_TEST_REPORTS=/tmp/circle-junit.aLqT5ZY (or similar), but cucumber tries to write to /home/ubuntu/<project-name>/tmp/circle-junit.aLqT5ZY/cucumber/tests.cucumber instead of /tmp/circle-junit.aLqT5ZY/cucumber/tests.cucumber, as defined by the environment variable.

travi added a commit to travi-org/admin.travi.org that referenced this issue Aug 11, 2017
@charlierudolph
Copy link
Member

I believe if we switch path.join to path.resolve that will fix the issue. We should add a feature test for this where it supplies an absolute path into a temp directory.

@charlierudolph charlierudolph added 🙏 help wanted Help wanted - not prioritized by core team good first issue Good for newcomers labels Aug 11, 2017
travi-bot pushed a commit to travi-org/admin.travi.org that referenced this issue Aug 11, 2017
@travi
Copy link
Member Author

travi commented Aug 23, 2017

Thanks @charlierudolph and @darrinholst !

@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers 🙏 help wanted Help wanted - not prioritized by core team
Projects
None yet
Development

No branches or pull requests

2 participants