i18n

[jbpros]

Add support for all Gherkin's spoken languages. The # language: xx comment directive should be recognized.

This will probably impact the undefined step definition snippets.

[fodor0205]

I would be happy to see this feature implemented.

[jbpros]

Thanks to recent changes in Gherkin.js, this will be easier to implement. I moved it from the 0.5 milestone to 0.4.

[ldegen]

hi everyone,
It seems we are almost there:

There was an encoding issue in gherkin, cucumber/gherkin#225, but that is fixed in 2.12.2.
I just had another look at #116, which I understand is based on #109.
I added a trivial modification to the regexp used to detect the language directive and rebased it on top of the current master of the original repository.

The result is here: ldegen/cucumber-js@0beabd4

As far as I can tell, it works as it should. In fact, we are using this right now on a real project with German scenarios, umlauts and all. No problems thus far.

I am not sure how to proceed now. Should I start another pull request?
There should probably be some scenarios in features/cucumber-tck/i18n.feature?

cheers,
--lu

[jbpros]

Thank you for this @ldegen.

Adding scenarios to the feature file and making them pass would indeed be the next step. Are you up for it? Please make another PR if you are.

[ldegen]

@jbpros, today I found myself with some time on my hands so I tried to pull (pun intended) this of.

I am not sure, if this is what you had in mind. I made a separate pull request cucumber-attic/cucumber-tck#15 to get the i18n scenarios into cucumber-tck, but of course those will fail for cucumber-js unless #156 is merged.
I would have prefered to put both in a single pull request, but I have no idea if this is even possible?

[ldegen]

Ah, btw, the generation of snippets for undefined steps is still missing. So you probably do not want to close this issue yet.

[jbpros]

@ldegen thank you for your great work on this. Your PR has been merged. Snippets are indeed not yet internationalised but that can be handled separately. The most important thing was to support other languages than english in Gherkin files.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.