-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.0.0 candidates #1290
Comments
@aslakhellesoy I looked at the compatibility kit a bit and don't see the binary the readme mentions to actually perform the check. |
@charlierudolph @aslakhellesoy I got something started for CCK validation here: Most of the differences are because things have moved on since gherkin 9 and messages 8 which we are depending on right now. Do we want to try and bring it up to the latest gherkin and messages before doing a 7.0.0 release? I'm happy to give that a go if it's the right thing to do. Also I think the CCK has quite a few changes that aren't yet published in the npm package https://github.com/cucumber/cucumber/tree/master/compatibility-kit/javascript. |
Upgrading gherkin / messages works for me. An long as cck if itself versioned and suppose to work with specific gherkn / messages that should be fine. |
Still working through these changes. @mpkorstanje @vincent-psarga are you able to do a release of the JavaScript CCK package with the latest changes? |
I wasn't aware those were released. If nobody else gets to it before the end of this week I'll give it a stab. |
@davidjgoss what do you exactly mean by a release of the CCK ? For Ruby for example, we don't package the CCK as a gem, we run the feature directly from the mono-repo against the code of You can see in the config.yml of cucumber-ruby how each build validates the CCK. |
@vincent-psarga the JS version of CCK has been packaged up and published to npm - the current published version 1.0.0 is a few months old though https://www.npmjs.com/package/@cucumber/compatibility-kit If the setup is already there for it, I think using CCK as an npm package would be the cleanest way for us to work with it (I'm not blocked on this right now as I have copied the content from the monorepo for the time being) |
Now that the cucumber org has control of the |
Yes, I think we should release as |
Per #1428 we have some confusion because of the state of master vs last published version. Would it be worth doing a “soft” 7.0.0 release and then publicising a closely-following 7.1.0 that includes the reports stuff? |
@charlierudolph @aslakhellesoy do we feel ready for 7.0.0? We do have #1416 open still |
Closing this now we (I think) have all the big changes in for 7.0.0 that we wanted. Not sure if we want to do another RC before an official 7.0.0? |
Discussion of what needs to be done before cutting a 7.0.0 release. There is a milestone created which concrete issues and PRs can be linked to once they are agreed here.
TypeScript
Gherkin & Messages
Rule
in out-of-box formatters (format: add support for gherkin rule/example syntax #1273)Other Breaking Changes?
Do we take the opportunity to make some other breaking changes?
Make CLI args case consistent (see cli: --retryTagFilter case inconsistent with other args #1291)Publish to npm under@cucumber/cucumber
in line with other packages (see build: scoped package name #1411)Change to how custom formatters are loaded to support external packages (see Load custom formatter by relative path only if it begins with a dot #1413)The text was updated successfully, but these errors were encountered: