Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript tasks #1269

Closed
6 tasks done
charlierudolph opened this issue Dec 28, 2019 · 3 comments · Fixed by #1414
Closed
6 tasks done

Typescript tasks #1269

charlierudolph opened this issue Dec 28, 2019 · 3 comments · Fixed by #1414
Milestone

Comments

@charlierudolph
Copy link
Member

charlierudolph commented Dec 28, 2019

Now that we have converted to Typescript have a few post merge tasks that would be nice:

Please comment if you think there are other tasks we should complete and I can add them to the list. Also comment if you start working on a task

@davidjgoss
Copy link
Contributor

davidjgoss commented Dec 28, 2019

Picking up the api-extractor thing if no one objects - won't be short but shouldn't conflict with any of the others.

Also think it might be good to put some guards in with https://www.npmjs.com/package/tsd so we test the typings against typical usages in support code and custom formatters.

@davidjgoss
Copy link
Contributor

davidjgoss commented Feb 3, 2020

Update from me - had a go with api-extractor but ran into a corner case issue where re-exporting the Status enum from cucumber-messages trips it up. I've gotten some help from the rushstack team and will dig in a little more this week.

Also I am picking up noImplicitReturns and noImplicitAny now

cc @charlierudolph

@davidjgoss
Copy link
Contributor

Draft PR raised for DefinitelyTyped DefinitelyTyped/DefinitelyTyped#47104 - will be mergeable once we release 7.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants