-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gherkin Rule keyword and Protocol Buffer messages #416
Gherkin Rule keyword and Protocol Buffer messages #416
Conversation
From #378 @charlierudolph:
I'm on the fence about this. Adding them to source control does simplify the build system. We already add the berp-generated Gherkin |
From #378 @charlierudolph:
It would be great if you could implement the I'll crack on with the JavaScript implementation. |
@SabotageAndi and/or @gasparnagy are you up for doing the .NET stuff? @brasmusson or anyone else in @cucumber/cucumber-ruby - who wants to work on the Ruby code? |
@aslakhellesoy I am full with work for the next 2-3 month. After that, perhaps. Hopefully @gasparnagy can work on it earlier. |
I can work on Ruby |
Great @bv! What questions do you have? I recommend starting with the messages library, which will have to use protobuf to generate the Ruby classes. |
…le-keyword-protobuf
commit 58fa366 Merge: 5a262c2 88c5f16 Author: mpkorstanje <[email protected]> Date: Fri Jul 6 11:48:27 2018 +0200 Merge branch 'master' into gherkin-6-cucumber-messages-protobuf commit 88c5f16 Author: Aslak Hellesøy <[email protected]> Date: Fri Jul 6 10:42:48 2018 +0100 Delete android, now moved to cucumber/cucumber-android commit 5a262c2 Merge: fd3ad3b 0fefc58 Author: Aslak Hellesøy <[email protected]> Date: Fri Jul 6 10:26:17 2018 +0100 Merge with master commit fd3ad3b Merge: 37db968 53d92b8 Author: Aslak Hellesøy <[email protected]> Date: Wed Jul 4 10:04:11 2018 +0100 Merge with master. Drop support for non UTF-8 encoding commit 37db968 Author: Aslak Hellesøy <[email protected]> Date: Wed Jun 27 10:21:04 2018 +0100 Update imports commit 46ce2a0 Author: Aslak Hellesøy <[email protected]> Date: Thu Jun 21 14:32:32 2018 +0100 Refactored to use Gherkin 6 / Protobuf. Removed JSON/HTML/Pretty/JUnit XML formatters and related cruft. See: * cucumber/common#416 * cucumber/common#415
commit 58fa366 Merge: 5a262c2 88c5f16 Author: mpkorstanje <[email protected]> Date: Fri Jul 6 11:48:27 2018 +0200 Merge branch 'master' into gherkin-6-cucumber-messages-protobuf commit 88c5f16 Author: Aslak Hellesøy <[email protected]> Date: Fri Jul 6 10:42:48 2018 +0100 Delete android, now moved to cucumber/cucumber-android commit 5a262c2 Merge: fd3ad3b 0fefc58 Author: Aslak Hellesøy <[email protected]> Date: Fri Jul 6 10:26:17 2018 +0100 Merge with master commit fd3ad3b Merge: 37db968 53d92b8 Author: Aslak Hellesøy <[email protected]> Date: Wed Jul 4 10:04:11 2018 +0100 Merge with master. Drop support for non UTF-8 encoding commit 37db968 Author: Aslak Hellesøy <[email protected]> Date: Wed Jun 27 10:21:04 2018 +0100 Update imports commit 46ce2a0 Author: Aslak Hellesøy <[email protected]> Date: Thu Jun 21 14:32:32 2018 +0100 Refactored to use Gherkin 6 / Protobuf. Removed JSON/HTML/Pretty/JUnit XML formatters and related cruft. See: * cucumber/common#416 * cucumber/common#415
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR adds a
Rule
keyword to the Gherkin grammar. TheGherkinDocument
AST also has aRule
node. The AST itself, as well asSource
andPickle
messages all use Protocol Buffers.This PR supercedes #378 and #414, and implements #250.
TODO:
messages
libraryASTBuilder
to usemessages
and rename toGherkinDocumentBuilder
event-protocol
modulemessages/README.md