Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gherkin/javascript: Include tags from rules in scenario outlines #2091

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

chaofan-nirvana
Copy link
Contributor

@chaofan-nirvana chaofan-nirvana commented Sep 30, 2022

See #2090

Copy link
Contributor

@luke-hill luke-hill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit. Good spot. Let a JS dev review / approve though

Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment on style, please also update the changelog.

gherkin/javascript/src/pickles/compile.ts Outdated Show resolved Hide resolved
@mpkorstanje mpkorstanje self-assigned this Oct 8, 2022
@mpkorstanje mpkorstanje changed the title Update the compileRule function of javascript gherkin/javascript: Include tags from rules in scenario outlines Oct 10, 2022
@mpkorstanje mpkorstanje merged commit 8321132 into cucumber:main Oct 10, 2022
@aslakhellesoy
Copy link
Contributor

Hi @chaofan-nirvana,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@ciaranmcnulty
Copy link
Contributor

Is it possible to add a new, or modify an existing, feature file from the testdata that would expose this difference?

@luke-hill
Copy link
Contributor

@mpkorstanje
Copy link
Contributor

I've got an MR for that in progress. It's not trivial, the code to generate the reference files is broken.

@mpkorstanje
Copy link
Contributor

Available in Gherkin 24.1.

@chaofan-nirvana
Copy link
Contributor Author

The cucumber and its community are so great! It is a good start for me. Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants