-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gherkin/javascript: Include tags from rules in scenario outlines #2091
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit. Good spot. Let a JS dev review / approve though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment on style, please also update the changelog.
c2f80a3
to
7d465fa
Compare
Hi @chaofan-nirvana, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
Is it possible to add a new, or modify an existing, feature file from the testdata that would expose this difference? |
Yes, we should. This one: https://github.com/cucumber/common/blob/main/gherkin/testdata/good/rule_with_tag.feature |
I've got an MR for that in progress. It's not trivial, the code to generate the reference files is broken. |
Available in Gherkin 24.1. |
The cucumber and its community are so great! It is a good start for me. Thank you all! |
See #2090