Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gherkin-c] Make gherkin-c up to date #1989

Merged
merged 12 commits into from
Aug 20, 2022
Merged

Conversation

brasmusson
Copy link
Contributor

@brasmusson brasmusson commented May 22, 2022

Summary

Update gherkin-c from v7.0.4 standard to v24.0.x standard

Details

Remaining work:

  • Add a plugin interface to the id generation
    Rather that having gherkin-c to know how to generated UUID:s, let the client of gherkin-c provide such a component. Thereby gherkin-c become less complex or have fewer dependencies.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • The change has been ported to Java.
  • The change has been ported to Ruby.
  • The change has been ported to JavaScript.
  • The change has been ported to Go.
  • The change has been ported to .NET.
  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG accordingly.

Update gherkin-c from v7.0.4 standard to v23.0.x standard
@brasmusson brasmusson marked this pull request as ready for review August 17, 2022 08:52
Copy link
Contributor

@aurelien-reeves aurelien-reeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not enough recent experience to do a proper, secure review of C code :'(

Regarding the build, and anything else, it looks fine

gherkin/c/README.md Show resolved Hide resolved
gherkin/c/include/error_event.h Show resolved Hide resolved
@brasmusson brasmusson merged commit 99ec202 into main Aug 20, 2022
@brasmusson brasmusson deleted the gherkin-c-make-up-to-date branch August 20, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants