Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add name property to hook schema #1914

Merged
merged 11 commits into from
Mar 3, 2022
Merged

add name property to hook schema #1914

merged 11 commits into from
Mar 3, 2022

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Mar 2, 2022

Summary

  • Add name as an optional field on the Hook schema
  • Teach fake-cucumber to populate that field
  • Add case to the compatibility kit

Motivation and Context

First part of cucumber/messages#73.

How Has This Been Tested?

via the compatibility kit.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • The change has been ported to Java.
  • The change has been ported to Ruby.
  • The change has been ported to JavaScript.
  • The change has been ported to Go.
  • The change has been ported to .NET.
  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG accordingly.

@aslakhellesoy
Copy link
Contributor

Rather than trying to make the JSON formatter work, I think we should delete it.

It was created as a fallback solution when we decided to remove the native JSON formatters. Now that we're keeping them, this tool is obsolete.

@davidjgoss
Copy link
Contributor Author

davidjgoss commented Mar 2, 2022

@aslakhellesoy well okay then! I'll raise a separate PR for that. I do love to delete things.

@davidjgoss davidjgoss marked this pull request as ready for review March 3, 2022 09:40
Copy link
Contributor

@aurelien-reeves aurelien-reeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🥳

@davidjgoss davidjgoss merged commit 2197a4c into main Mar 3, 2022
@davidjgoss davidjgoss deleted the messages-named-hooks branch March 3, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants