-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add name property to hook schema #1914
Conversation
Rather than trying to make the JSON formatter work, I think we should delete it. It was created as a fallback solution when we decided to remove the native JSON formatters. Now that we're keeping them, this tool is obsolete. |
@aslakhellesoy well okay then! I'll raise a separate PR for that. I do love to delete things. |
jq filter is not optional in all versions Refs. https://stackoverflow.com/a/48964481/13481235
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🥳
Summary
name
as an optional field on the Hook schemaMotivation and Context
First part of cucumber/messages#73.
How Has This Been Tested?
via the compatibility kit.
Screenshots (if appropriate):
Types of changes
Checklist: