Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert messages into a hybrid cjs/esm package #1756

Merged
merged 36 commits into from
Sep 24, 2021

Conversation

aurelien-reeves
Copy link
Contributor

@aurelien-reeves aurelien-reeves commented Sep 16, 2021

Summary

This is the continuation of the conversion of JavaScript packages into hybrid cjs/esm packages.

Refs. #1743

Checklist:

  • I've added tests for my code.
  • I have updated the CHANGELOG accordingly.
  • default.mk and Makefile requires some changes for the "clean" target to avoid deleting dist/cjs/package.json

aurelien-reeves and others added 19 commits September 9, 2021 15:09
That way we will avoid duplication of ts-node section in packages
tsconfig.json.

Once all module have been converted, we will be able to move the ts-node
configuration into the root level tsconfig.json.
@aurelien-reeves aurelien-reeves force-pushed the make-messages-esm-compatible branch from ee28287 to a795db5 Compare September 16, 2021 12:23
@aurelien-reeves aurelien-reeves mentioned this pull request Sep 16, 2021
Base automatically changed from make-cucumber-expressions-esm-compatible to main September 17, 2021 15:01
@aurelien-reeves
Copy link
Contributor Author

aurelien-reeves commented Sep 21, 2021

@aslakhellesoy I think this is ready for review :)

message-streams/javascript/.gitignore Outdated Show resolved Hide resolved
message-streams/javascript/default.mk Outdated Show resolved Hide resolved
message-streams/javascript/package.json Outdated Show resolved Hide resolved
@aurelien-reeves
Copy link
Contributor Author

@aslakhellesoy one last review? 😊

Copy link
Contributor

@aslakhellesoy aslakhellesoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great work!!

@aurelien-reeves aurelien-reeves merged commit f1570e2 into main Sep 24, 2021
@aurelien-reeves aurelien-reeves deleted the make-messages-esm-compatible branch September 24, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants