-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert messages into a hybrid cjs/esm package #1756
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way we will avoid duplication of ts-node section in packages tsconfig.json. Once all module have been converted, we will be able to move the ts-node configuration into the root level tsconfig.json.
…s/package.json' files
…ions-esm-compatible
aurelien-reeves
force-pushed
the
make-messages-esm-compatible
branch
from
September 16, 2021 12:23
ee28287
to
a795db5
Compare
Closed
…sages-esm-compatible
Base automatically changed from
make-cucumber-expressions-esm-compatible
to
main
September 17, 2021 15:01
aurelien-reeves
added
⚡ enhancement
Request for new functionality
library: cucumber-messages
language: javascript
labels
Sep 21, 2021
@aslakhellesoy I think this is ready for review :) |
@aslakhellesoy one last review? 😊 |
aslakhellesoy
approved these changes
Sep 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Great work!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the continuation of the conversion of JavaScript packages into hybrid cjs/esm packages.
Refs. #1743
Checklist:
dist/cjs/package.json