Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of Cucumber messages for Perl #1670

Merged
merged 12 commits into from
Sep 1, 2021
Merged

Initial implementation of Cucumber messages for Perl #1670

merged 12 commits into from
Sep 1, 2021

Conversation

aurelien-reeves
Copy link
Contributor

@aurelien-reeves aurelien-reeves commented Jul 21, 2021 •
edited by ehuelsmann
Loading

Types of changes

  • New feature (non-breaking change which adds functionality).

Checklist:

  • I've added tests for my code.
  • I have updated the CHANGELOG accordingly.

@ehuelsmann ehuelsmann force-pushed the messages-perl branch 2 times, most recently from 0379832 to f8595e4 Compare July 22, 2021 06:52
@ehuelsmann ehuelsmann force-pushed the messages-perl branch 4 times, most recently from d9034ee to 344819c Compare July 22, 2021 19:45
@ehuelsmann ehuelsmann changed the title Rough outline of Cucumber::Messages::* for Perl Initial implementation of Cucumber messages for Perl Jul 22, 2021
@aurelien-reeves
Copy link
Contributor Author

aurelien-reeves commented Jul 23, 2021 •
edited
Loading

Caution: there is already a default.mk for perl in the templates.

At some point we will have to move your code from the default.mk you have created into the one in templates/perl, and rsync the files to other modules which have perl implementations.

Edit: I noticed that there may have been an attempt in #1673?

@ehuelsmann
Copy link
Contributor

Caution: there is already a default.mk for perl in the templates.

At some point we will have to move your code from the default.mk you have created into the one in templates/perl, and rsync the files to other modules which have perl implementations.

Edit: I noticed that there may have been an attempt in #1673?

Yes, that was an attempt, based on misunderstanding the situation. I've since merged a better version and rebased this branch. By setting up a '.rsync' file to ensure the shared infrastructure remains current, this new library should now be integrated in the regular build infrastructure.

@ehuelsmann ehuelsmann marked this pull request as ready for review July 23, 2021 09:59
@ehuelsmann
Initial commit for Perl implementation of cucumber messages
c295329
@ehuelsmann
Add messages-perl to the build and release infrastructure
90fed17
@ehuelsmann
Add README.md and update CHANGELOG.md
b45bc0f 
[skip ci]
@ehuelsmann
Add documentation to Cucumber::Messages
3489ab6 
Since Cucumber::Messages has been appointed the "main module", its
documentation will be shown on the "homepage" of the dist on
metacpan.org. So, try to provide the minimal set of generally expected
documentation sections for a Perl dist.
@ehuelsmann
Enable author tests when running make test
cae41e8
@ehuelsmann
Set up synchronization of shared build infrastructure
315faea
@ehuelsmann
Reduce chances of unversioned files included in the dist
fb8dbc3 
The `GatherDir` (default) plugin doesn't know about versioned or unversioned
files. `Git::GatherDir` does and only includes versioned files, unless
explicitly instructed differently (both about in- as well as exclusion).
@ehuelsmann
After review, add Cucumber Ltd to the list of copyright holders
66a77aa
@ehuelsmann
Complete documentation of Cucumber::Messages::Message
143d6c6
@ehuelsmann ehuelsmann requested a review from aslakhellesoy July 28, 2021 13:00
@aslakhellesoy aslakhellesoy merged commit 48bc4a3 into main Sep 1, 2021
@aslakhellesoy aslakhellesoy deleted the messages-perl branch September 1, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuelsmann ehuelsmann ehuelsmann left review comments

@mattwynne mattwynne Awaiting requested review from mattwynne

@aslakhellesoy aslakhellesoy Awaiting requested review from aslakhellesoy

Assignees
No one assigned
Labels
language: perl library: cucumber-messages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aurelien-reeves @ehuelsmann @aslakhellesoy @mattwynne