-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gherkin to use Messages DTOs instead of plain ruby hashes #1603
Conversation
@aurelien-reeves after merging this, can we cut a new version of gherkin so I can then get my PR updated in the regular cucumber-ruby |
That's the plan We have to write a json serializer for those DTOs But it is going well at the moment :) |
Isn't |
This is not javascript, this is ruby |
Once #1605 is merged, I'll be able to continue on this one. Hopefully there won't be too much to do to make it pass. |
If no objection soon, I'll force-merge it to be able to start releasing new versions of some modules in the mono-repo If any objection, I'll wait for proper reviews :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Requires #1601 to be merged first
Refs. #1559