Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gherkin to use Messages DTOs instead of plain ruby hashes #1603

Merged
merged 13 commits into from
Jul 7, 2021

Conversation

aurelien-reeves
Copy link
Contributor

@aurelien-reeves aurelien-reeves commented Jun 9, 2021

Requires #1601 to be merged first
Refs. #1559

@luke-hill
Copy link
Contributor

@aurelien-reeves after merging this, can we cut a new version of gherkin so I can then get my PR updated in the regular cucumber-ruby

@aurelien-reeves
Copy link
Contributor Author

@aurelien-reeves after merging this, can we cut a new version of gherkin so I can then get my PR updated in the regular cucumber-ruby

That's the plan
But it is not finished yet.

We have to write a json serializer for those DTOs
And to check the compatibility of all the modules with those new messages and gherkin.

But it is going well at the moment :)

@aslakhellesoy
Copy link
Contributor

Isn't JSON.stringify(envelope) enough?

@aurelien-reeves
Copy link
Contributor Author

Isn't JSON.stringify(envelope) enough?

This is not javascript, this is ruby

@aurelien-reeves
Copy link
Contributor Author

Once #1605 is merged, I'll be able to continue on this one. Hopefully there won't be too much to do to make it pass.

@aurelien-reeves
Copy link
Contributor Author

If no objection soon, I'll force-merge it to be able to start releasing new versions of some modules in the mono-repo

If any objection, I'll wait for proper reviews :)

Copy link
Contributor

@aslakhellesoy aslakhellesoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aurelien-reeves aurelien-reeves merged commit 57b3926 into main Jul 7, 2021
@aurelien-reeves aurelien-reeves deleted the gherkin-ruby-use-messages-dtos branch July 7, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants