Improve two step failure messages #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two things: - It requires all commands to have no output on the channel, not just one. - It improves the failure message so that it shows the actual output.
This fixes the failure message of the output comparison so that it shows the correct diff.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve step failure messages for two provided cucumber steps. Also, fix logic of one of the steps so it does what the wording says it does.
Details
Motivation and Context
This fixes #942.
How Has This Been Tested?
I added cucumber scenarios testing the failure case for both steps, and after implementing the fix I ran the whole test suite to verify that I didn't break anything.
Types of changes
Checklist: