Improve clarity of environment manipulation #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvz
force-pushed
the
refactor-with-environment
branch
from
aad9626 to
4ee2ab7
Compare
This does two things: - Avoid having two methods #with_environment that, apart from operating at a different level, also use their arguments differently: one takes changes to the environment as an argument, the other takes a full replacement environment. - Decouple LocalEnvironment from the global platform singleton. This is neater because it makes the dependency go only one way.
mvz
force-pushed
the
refactor-with-environment
branch
from
4ee2ab7 to
279d217
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cleans up code related to environment manipulation.
Details
This does two things:
It avoids having two methods
#with_environmentthat, apart from operating at a different level, also use their arguments differently: one takes changes to the environment as an argument, the other takes a full replacement environment.It decouples LocalEnvironment from the global platform singleton. This is neater because it makes the dependency go only one way.
Motivation and Context
I just spent quite some time looking at the wrong
#with_environmentand wondering how any environment variables could be left inside the block.How Has This Been Tested?
CI will test it.
Types of changes