Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous method definitions from specs #923

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Apr 1, 2024

Summary

Removes some unused spec helper methods.

Details

Specs contained helper methdos that were defined but never used. This change removes them.

Motivation and Context

Originally part of #881, but since that change turned out to be a bit more complex than expected, I'm presenting it separately here.

How Has This Been Tested?

I ran the specs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Internal change (refactoring, test improvements, developer experience or update of dependencies)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

These methods were defined but never used.
@mvz mvz merged commit 8bb4b02 into main Apr 1, 2024
18 checks passed
@mvz mvz deleted the remove-superfluous-rspec-helper-methods branch April 1, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant