Allow for type input of frozen strings #909
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some codebases follow the convention of enforcing frozen string literals, e.g. by using a
# frozen_string_literal: true
magic comment or viaRUBYOPT
.The current implementation of the
type
API Command breaks when this is the case, as it mutates the string passed to it to add a newline.Details
To avoid this, this PR tweaks the implementation to use interpolation rather than mutating the string input value.
Motivation and Context
Allows the
type
API Command to be used in codebases that enforce frozen string literals.How Has This Been Tested?
I've added a test case to the existing specs for
Aruba::Api::Commands#run_command
to assert that frozen strings can be passed as an input value.Types of changes
Checklist: