Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions to run specs on Windows on all supported Rubies #893

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Jan 22, 2023

Summary

Extends the GitHub Actions jobs to run the specs on Windows on all supported Rubies

Details

This is a follow-up for #892.

Since ChildProcess is no longer used, running the specs on Ruby 3.1 and 3.2 should work.

Motivation and Context

Closes #871.

How Has This Been Tested?

CI

Types of changes

  • Internal change (refactoring, test improvements, developer experience or update of dependencies)

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a nice change!

@mvz mvz force-pushed the run-specs-on-windows-on-all-rubies branch from 882c6d3 to 54bcf65 Compare February 12, 2023 13:41
wtsnjp added a commit to TeX-Live/texdoc that referenced this pull request Feb 20, 2023
updating ruby itself to 3.2.x will result in Windows CI errors.
see cucumber/aruba#893
@mvz mvz force-pushed the run-specs-on-windows-on-all-rubies branch from 54bcf65 to cfc5a99 Compare December 24, 2023 17:50
@mvz mvz merged commit 639f0d6 into main Dec 25, 2023
19 checks passed
@mvz mvz deleted the run-specs-on-windows-on-all-rubies branch December 25, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants