Replace ChildProcess with Process.spawn

Appraisals

@@ -2,25 +2,20 @@
 
 appraise "cucumber_4" do
   gem "cucumber", "~> 4.0"
-  gem "childprocess", "~> 2.0.0"
 end
 
 appraise "cucumber_5" do
   gem "cucumber", "~> 5.0"
-  gem "childprocess", "~> 3.0.0"
 end
 
 appraise "cucumber_6" do
   gem "cucumber", "~> 6.0"
-  gem "childprocess", "~> 4.0"
 end
 
 appraise "cucumber_7" do
   gem "cucumber", "~> 7.0"
-  gem "childprocess", "~> 4.0"
 end
 
 appraise "cucumber_8" do
   gem "cucumber", "~> 8.0"
-  gem "childprocess", "~> 4.0"
 end

aruba.gemspec

@@ -22,7 +22,6 @@ Gem::Specification.new do |spec|
   }
 
   spec.add_runtime_dependency "bundler", [">= 1.17", "< 3.0"]
-  spec.add_runtime_dependency "childprocess", [">= 2.0", "< 5.0"]
   spec.add_runtime_dependency "contracts", [">= 0.16.0", "< 0.18.0"]
   spec.add_runtime_dependency "cucumber", ">= 4.0", "< 9.0"
   spec.add_runtime_dependency "rspec-expectations", "~> 3.4"

gemfiles/cucumber_4.gemfile

@@ -3,6 +3,5 @@
 source "https://rubygems.org"
 
 gem "cucumber", "~> 4.0"
-gem "childprocess", "~> 2.0.0"
 
 gemspec path: "../"

gemfiles/cucumber_5.gemfile

@@ -3,6 +3,5 @@
 source "https://rubygems.org"
 
 gem "cucumber", "~> 5.0"
-gem "childprocess", "~> 3.0.0"
 
 gemspec path: "../"

gemfiles/cucumber_6.gemfile

@@ -3,6 +3,5 @@
 source "https://rubygems.org"
 
 gem "cucumber", "~> 6.0"
-gem "childprocess", "~> 4.0"
 
 gemspec path: "../"

gemfiles/cucumber_7.gemfile

@@ -3,6 +3,5 @@
 source "https://rubygems.org"
 
 gem "cucumber", "~> 7.0"
-gem "childprocess", "~> 4.0"
 
 gemspec path: "../"

gemfiles/cucumber_8.gemfile

@@ -3,6 +3,5 @@
 source "https://rubygems.org"
 
 gem "cucumber", "~> 8.0"
-gem "childprocess", "~> 4.0"
 
 gemspec path: "../"

lib/aruba/cucumber/command.rb

@@ -81,7 +81,7 @@
       sleep 0.1
     end
   end
-rescue ChildProcess::TimeoutError, Timeout::Error
+rescue Timeout::Error
   last_command_started.terminate
 end
 

lib/aruba/platforms/unix_platform.rb

@@ -241,6 +241,10 @@ def which(program, path = ENV["PATH"])
       def builtin_shell_commands
         []
       end
+
+      def term_signal_supported?
+        true
+      end
     end
   end
 end

lib/aruba/platforms/windows_command_string.rb

@@ -4,8 +4,6 @@ module Aruba
   module Platforms
     # This is a command which should be run
     #
-    # This adds `cmd.exec` in front of commmand
-    #
     # @private
     class WindowsCommandString
       def initialize(command, *arguments)
@@ -15,22 +13,7 @@ def initialize(command, *arguments)
 
       # Convert to array
       def to_a
-        [cmd_path, "/c", [escaped_command, *escaped_arguments].join(" ")]
-      end
-
-      private
-
-      def escaped_arguments
-        @arguments.map { |arg| arg.gsub(/"/, '"""') }
-                  .map { |arg| / /.match?(arg) ? "\"#{arg}\"" : arg }
-      end
-
-      def escaped_command
-        @command.gsub(/ /, '""" """')
-      end
-
-      def cmd_path
-        Aruba.platform.which("cmd.exe")
+        [@command, *@arguments]
       end
     end
   end

lib/aruba/platforms/windows_platform.rb

@@ -39,6 +39,10 @@ def which(program, path = ENV["PATH"])
       def builtin_shell_commands
         %w(cd dir echo exit set type)
       end
+
+      def term_signal_supported?
+        false
+      end
     end
   end
 end

lib/aruba/processes/spawn_process.rb

@@ -1,4 +1,3 @@
-require "childprocess"
 require "tempfile"
 require "shellwords"
 
@@ -10,6 +9,85 @@
 module Aruba
   # Platforms
   module Processes
+    # Wrapper around Process.spawn that broadly follows the ChildProcess interface
+    # @private
+    class ProcessRunner
+      def initialize(command_array)
+        @command_array = command_array
+        @exit_status = nil
+      end
+
+      attr_accessor :stdout, :stderr, :cwd, :environment
+      attr_reader :command_array, :pid
+
+      def start
+        @stdin_r, @stdin_w = IO.pipe
+        @pid = Process.spawn(environment, *command_array,
+                             unsetenv_others: true,
+                             in: @stdin_r,
+                             out: stdout.fileno,
+                             err: stderr.fileno,
+                             close_others: true,
+                             chdir: cwd)
+      end
+
+      def stdin
+        @stdin_w
+      end
+
+      def stop
+        return if @exit_status
+
+        if Aruba.platform.term_signal_supported?
+          send_signal "TERM"
+          return if poll_for_exit(3)
+        end
+
+        send_signal "KILL"
+        wait
+      end
+
+      def wait
+        _, status = Process.waitpid2 @pid
+        @exit_status = status
+      end
+
+      def exited?
+        return true if @exit_status
+
+        pid, status = Process.waitpid2 @pid, Process::WNOHANG | Process::WUNTRACED
+
+        if pid
+          @exit_status = status
+          return true
+        end
+
+        false
+      end
+
+      def poll_for_exit(exit_timeout)
+        start = Time.now
+        wait_until = start + exit_timeout
+        loop do
+          return true if exited?
+          break if Time.now >= wait_until
+
+          sleep 0.1
+        end
+        false
+      end
+
+      def exit_code
+        @exit_status&.exitstatus
+      end
+
+      private
+
+      def send_signal(signal)
+        Process.kill signal, @pid
+      end
+    end
+
     # Spawn a process for command
     #
     # `SpawnProcess` is not meant for direct use - `SpawnProcess.new` - by
@@ -74,7 +152,8 @@ def start
 
         @started = true
 
-        @process = ChildProcess.build(*command_string.to_a)
+        @process = ProcessRunner.new(command_string.to_a)
+
         @stdout_file = Tempfile.new("aruba-stdout-")
         @stderr_file = Tempfile.new("aruba-stderr-")
 
@@ -85,21 +164,19 @@ def start
         @stderr_file.set_encoding("ASCII-8BIT")
 
         @exit_status = nil
-        @duplex      = true
 
         before_run
 
-        @process.io.stdout = @stdout_file
-        @process.io.stderr = @stderr_file
-        @process.duplex    = @duplex
-        @process.cwd       = @working_directory
+        @process.stdout = @stdout_file
+        @process.stderr = @stderr_file
+        @process.cwd    = @working_directory
 
-        @process.environment.update(environment)
+        @process.environment = environment
 
         begin
           @process.start
           sleep startup_wait_time
-        rescue ChildProcess::LaunchError => e
+        rescue SystemCallError => e
           raise LaunchError, "It tried to start #{commandline}. " + e.message
         end
 
@@ -129,7 +206,7 @@ def stdout(opts = {})
         return @stdout_cache if stopped?
 
         wait_for_io opts.fetch(:wait_for_io, io_wait_timeout) do
-          @process.io.stdout.flush
+          @process.stdout.flush
           open(@stdout_file.path).read
         end
       end
@@ -148,16 +225,16 @@ def stderr(opts = {})
         return @stderr_cache if stopped?
 
         wait_for_io opts.fetch(:wait_for_io, io_wait_timeout) do
-          @process.io.stderr.flush
+          @process.stderr.flush
           open(@stderr_file.path).read
         end
       end
 
       def write(input)
         return if stopped?
 
-        @process.io.stdin.write(input)
-        @process.io.stdin.flush
+        @process.stdin.write(input)
+        @process.stdin.flush
 
         self
       end
@@ -166,18 +243,14 @@ def write(input)
       def close_io(name)
         return if stopped?
 
-        @process.io.public_send(name.to_sym).close
+        @process.public_send(name.to_sym).close
       end
 
       # Stop command
       def stop(*)
         return @exit_status if stopped?
 
-        begin
-          @process.poll_for_exit(@exit_timeout)
-        rescue ChildProcess::TimeoutError
-          @timed_out = true
-        end
+        @process.poll_for_exit(@exit_timeout) or @timed_out = true
 
         terminate
       end

spec/aruba/platforms/windows_command_string_spec.rb

@@ -2,24 +2,19 @@
 
 RSpec.describe Aruba::Platforms::WindowsCommandString do
   let(:command_string) { described_class.new(base_command, *arguments) }
-  let(:cmd_path) { 'C:\Some Path\cmd.exe' }
   let(:arguments) { [] }
 
-  before do
-    allow(Aruba.platform).to receive(:which).with("cmd.exe").and_return(cmd_path)
-  end
-
   describe "#to_a" do
     context "with a command with a path" do
       let(:base_command) { "C:\\Foo\\Bar" }
 
-      it { expect(command_string.to_a).to eq [cmd_path, "/c", base_command] }
+      it { expect(command_string.to_a).to eq [base_command] }
     end
 
     context "with a command with a path containing spaces" do
       let(:base_command) { "C:\\Foo Bar\\Baz" }
 
-      it { expect(command_string.to_a).to eq [cmd_path, "/c", 'C:\Foo""" """Bar\Baz'] }
+      it { expect(command_string.to_a).to eq [base_command] }
     end
 
     context "with a command and arguments" do
@@ -28,7 +23,7 @@
 
       it {
         expect(command_string.to_a)
-          .to eq [cmd_path, "/c", "#{base_command} -w \"baz quux\""]
+          .to eq [base_command, *arguments]
       }
     end
   end