Fix steps that wait for output from commands #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvz
force-pushed
the
fix-waiting-for-stdout
branch
from
86e932c to
f71450d
Compare
By changing the printed text, the first iteration will already print text that is not part of the echoed command. Therefore, we can trigger termination after the first iteration instead of the second. To avoid slower termination failing the scenario, allow for Test 1 to be output, and just require Test 2 not to appear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the 'wait for output to contain' steps
Details
Motivation and Context
Fixes #854.
How Has This Been Tested?
Three new scenarios test this functionality.
Types of changes
Checklist: