Fix getting started with minitest framework feature #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ooops!! Sorry!!
In order to fix the error that currently breaks the build:
1) Error:
FirstRun#test_getting_started_with_aruba:
RuntimeError: Calling #must_equal outside of test.
test/use_aruba_with_minitest.rb:18:in `test_getting_started_with_aruba'
1 runs, 0 assertions, 0 failures, 1 errors, 0 skips
|
Thanks @nando! That looks good. Can you please rebase this on current master and combine commits to get rid of the 'oops' commits? |
|
@nando do you need any help rebasing this? |
|
Superseded by #921. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I followed the Getting Started with Aruba feature in order to use Aruba in my Minitest build and discovered a typo in the Aruba's setup method name, and also the reason why it wasn't detected by Aruba's current build: the test method name in the feature didn't start with "test_", so it never runs.
Details