Update supported set of rubies #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
approved these changes
Dec 31, 2019
When running under childprocess, IRB does not activate readline. This means history is not collected and the history file is empty if saved. In Ruby 2.7, the file is not even written to. This means saving the history file cannot properly be tested on Ruby 2.7 using Aruba. Instead, we check that the correct file is configured in IRB, and just assume IRB will do the right thing with it.
mvz
force-pushed
the
update-supported-set-of-rubies
branch
from
40acdc5 to
278db20
Compare
mvz
force-pushed
the
update-supported-set-of-rubies
branch
from
d19389c to
eab2038
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Drop support for Ruby 2.3 in master, so Aruba 1.0.0 will target 2.4+
Details
Updates build set on Travis, and sets minimum supported version in gemspec and RuboCop config.
Motivation and Context
Ruby 2.3 has been deprecated for a long time, we can't get the JRuby 9.1 build working on Travis' Xenial environment, and even 2.4 is nearing its end-of-life.
How Has This Been Tested?
Travis will run it!
Types of changes
Checklist: