Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up a few of the LineLength cops #659

Merged
merged 1 commit into from
Jul 20, 2019
Merged

Fix up a few of the LineLength cops #659

merged 1 commit into from
Jul 20, 2019

Conversation

luke-hill
Copy link
Contributor

Summary

Attempt to begin to fix the vast quantity of LineLength offenses (Some are 250+ chars)

Details

Manually tweak some lines to get some quick wins, tackle the largest offenders first.

Motivation and Context

To try get the master branch under better rubocop conformation

How Has This Been Tested?

CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (cleanup of codebase without changing any existing functionality)
  • Update documentation

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@luke-hill luke-hill requested a review from mvz July 15, 2019 09:56
@mvz mvz force-pushed the refactor/line_length_cop branch from 44e3583 to 8a6cfb5 Compare July 20, 2019 06:19
@mvz mvz merged commit 20c1814 into master Jul 20, 2019
@mvz mvz deleted the refactor/line_length_cop branch July 20, 2019 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants