-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve appveyor build: Specs part #618
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing default is not needed, since ENV is always used as a base for the local environment.
- Use inject on all versions of Ruby, not need to make a distinction here. - Clean up overrides in WindowsEnvironmentVariables - Override to_h in WindowsEnvironmentVariables so it correctly upcases ENV values.
SpawnProcess should work without specifying these, and there are no specs that essentially override these defaults.
Instead of setting up or using a shell script, just use Ruby with a script on the command line.
This splits the specs in a Unix and Windows versions, just like for the specs for commands with spaces.
This method basically returns one of the initializer arguments so makes little sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Work towards a green build on AppVeyor for just the specs
Details
Motivation and Context
I want to get at least part of #505 merged but the cucumber part is tough.
How Has This Been Tested?
Specs have been run on Linux, AppVeyor will check Windows.
Types of changes