Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies (still branch) #591

Merged
merged 2 commits into from
Feb 1, 2019
Merged

Update dependencies (still branch) #591

merged 2 commits into from
Feb 1, 2019

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Feb 1, 2019

Summary

Update some dependencies

Details

Updates dependencies on kramdown and childprocess

Motivation and Context

The dependency on childprocess is most important, because it affects users. Loosening our dependency on childprocess will allow them to use the latest childprocess in their projects. The update of kramdown is just nice for Aruba developers.

How Has This Been Tested?

The update of kramdown was tested by running yardoc. That lead to a change in the Gemfile to explicitely depend on yard, since otherwise its presence in the bundle is only accidental. The change in the dependency on childprocess will be tested by Travis.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (cleanup of codebase without changing any existing functionality)
  • Update documentation

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

mvz added 2 commits February 1, 2019 16:04
- Use kramdown 2.1 on newer Rubies
- Also explicitely depend on yard, rather than through pry-doc
@mvz mvz changed the title Update dependencies Update dependencies (still branch) Feb 1, 2019
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a thoughtful addition.

@mvz mvz merged commit 6ed7a7e into still Feb 1, 2019
@mvz mvz deleted the update-dependencies-still branch February 1, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants